Skip to content

GCC 5 -Wall issues warning about clang::fallthrough attribute placement in string_view header #42

@acmorrow

Description

@acmorrow

When building libbsoncxx against core HEAD with -Wall, I'm getting lots of warnings about the use of the clang::fallthrough attribute in the new string_view header:

src/bsoncxx/third_party/EP_mnmlstc_core-prefix/src/EP_mnmlstc_core/include/core/string_view.hpp:100:55: warning: attributes at the beginning of statement are ignored [-Wattributes]
       case 2: hash ^= ::std::uint64_t(data[1]) << 8;  [[clang::fallthrough]];

Easy enough to work around by adding -Wno-attribute but that is not ideal.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions