newdata refactoring

bblodfon · bblodfon · commit 29f74417950a · 2025-10-06T15:07:16.000+03:00
diff --git a/R/LearnerDensKDE.R b/R/LearnerDensKDE.R
@@ -86,7 +86,8 @@ LearnerDensKDE = R6Class("LearnerDensKDE",
     },
 
     .predict = function(task) {
-      list(pdf = self$model$pdf(task$data()[[1L]]), distr = self$model)
+      newdata = task$data()[[1]]
+      list(pdf = self$model$pdf(newdata), distr = self$model)
     }
   )
 )
diff --git a/R/LearnerDensKDEks.R b/R/LearnerDensKDEks.R
@@ -66,7 +66,8 @@ LearnerDensKDEks = R6Class("LearnerDensKDEks",
     },
 
     .predict = function(task) {
-      list(pdf = self$model$pdf(task$data()[[1]]))
+      newdata = task$data()[[1]]
+      list(pdf = self$model$pdf(newdata))
     }
   )
 )
diff --git a/R/LearnerDensLocfit.R b/R/LearnerDensLocfit.R
@@ -70,7 +70,8 @@ LearnerDensLocfit = R6Class("LearnerDensLocfit",
     },
 
     .predict = function(task) {
-      list(pdf = self$model$pdf(task$data()[[1]]))
+      newdata = task$data()[[1]]
+      list(pdf = self$model$pdf(newdata))
     }
   )
 )
diff --git a/R/LearnerDensLogspline.R b/R/LearnerDensLogspline.R
@@ -76,7 +76,6 @@ LearnerDensLogspline = R6Class("LearnerDensLogspline",
 
     .predict = function(task) {
       newdata = task$data()[[1]]
-
       list(pdf = self$model$pdf(newdata), cdf = self$model$cdf(newdata))
     }
   )

Original file line number	Diff line number	Diff line change
`@@ -86,7 +86,8 @@ LearnerDensKDE = R6Class("LearnerDensKDE",`
`86`	`86`	`},`
`87`	`87`
`88`	`88`	`.predict = function(task) {`
`89`		`- list(pdf = self$model$pdf(task$data()[[1L]]), distr = self$model)`
	`89`	`+ newdata = task$data()[[1]]`
	`90`	`+ list(pdf = self$model$pdf(newdata), distr = self$model)`
`90`	`91`	`}`
`91`	`92`	`)`
`92`	`93`	`)`
Original file line number	Diff line number	Diff line change
`@@ -66,7 +66,8 @@ LearnerDensKDEks = R6Class("LearnerDensKDEks",`
`66`	`66`	`},`
`67`	`67`
`68`	`68`	`.predict = function(task) {`
`69`		`- list(pdf = self$model$pdf(task$data()[[1]]))`
	`69`	`+ newdata = task$data()[[1]]`
	`70`	`+ list(pdf = self$model$pdf(newdata))`
`70`	`71`	`}`
`71`	`72`	`)`
`72`	`73`	`)`
Original file line number	Diff line number	Diff line change
`@@ -70,7 +70,8 @@ LearnerDensLocfit = R6Class("LearnerDensLocfit",`
`70`	`70`	`},`
`71`	`71`
`72`	`72`	`.predict = function(task) {`
`73`		`- list(pdf = self$model$pdf(task$data()[[1]]))`
	`73`	`+ newdata = task$data()[[1]]`
	`74`	`+ list(pdf = self$model$pdf(newdata))`
`74`	`75`	`}`
`75`	`76`	`)`
`76`	`77`	`)`
Original file line number	Diff line number	Diff line change
`@@ -76,7 +76,6 @@ LearnerDensLogspline = R6Class("LearnerDensLogspline",`
`76`	`76`
`77`	`77`	`.predict = function(task) {`
`78`	`78`	`newdata = task$data()[[1]]`
`79`		`-`
`80`	`79`	`list(pdf = self$model$pdf(newdata), cdf = self$model$cdf(newdata))`
`81`	`80`	`}`
`82`	`81`	`)`