refactor: match mlr3 style for j in data table

m-muecke · m-muecke · commit 1c5639439fe0 · 2025-09-14T13:39:08.000+02:00
diff --git a/R/ResamplingFcstCV.R b/R/ResamplingFcstCV.R
@@ -132,7 +132,7 @@ ResamplingFcstCV = R6Class(
             list(train_ids = train_ids, test_ids = test_ids)
           },
           by = key_cols
-        ][, .(train_ids, test_ids)]
+        ][, list(train_ids, test_ids)]
         train_ids = ids$train_ids
         test_ids = ids$test_ids
       }
diff --git a/R/TaskFcstElectricty.R b/R/TaskFcstElectricty.R
@@ -18,7 +18,7 @@ load_task_electricty = function(id = "electricity") {
   dt = as.data.table(load_dataset("vic_elec", "tsibbledata"))
   setnames(dt, tolower)
   demand = temperature = holiday = NULL
-  dt = dt[, .(demand = sum(demand), temperature = max(temperature), holiday = any(holiday)), by = date]
+  dt = dt[, list(demand = sum(demand), temperature = max(temperature), holiday = any(holiday)), by = date]
   b = as_data_backend(dt)
 
   task = TaskFcst$new(
diff --git a/R/as_task_fcst.R b/R/as_task_fcst.R
@@ -100,7 +100,7 @@ as_task_fcst.data.frame = function(
 
   has_dups = NULL
   dup = if (has_key) {
-    x[, .(has_dups = anyDuplicated(get(order)) > 0L), by = key][, any(has_dups)]
+    x[, list(has_dups = anyDuplicated(get(order)) > 0L), by = key][, any(has_dups)]
   } else {
     anyDuplicated(x[[order]]) > 0L
   }
diff --git a/R/tsf.R b/R/tsf.R
@@ -82,7 +82,7 @@ read_tsf = function(file) {
     }
   }
 
-  dt_long = dt[, .(value = strsplit1(value, ",")), by = col_names]
+  dt_long = dt[, list(value = strsplit1(value, ",")), by = col_names]
   dt_long["?", value := NA_character_, on = "value"]
   dt_long[, value := as.numeric(value)]
   dt[, value := NULL]
diff --git a/R/zzz.R b/R/zzz.R
@@ -9,8 +9,6 @@
 #' @importFrom stats as.ts
 "_PACKAGE"
 
-utils::globalVariables(".")
-
 mlr3forecast_resamplings = new.env()
 mlr3forecast_tasks = new.env()
 mlr3forecast_learners = new.env()

Original file line number	Diff line number	Diff line change
`@@ -132,7 +132,7 @@ ResamplingFcstCV = R6Class(`
`132`	`132`	`list(train_ids = train_ids, test_ids = test_ids)`
`133`	`133`	`},`
`134`	`134`	`by = key_cols`
`135`		`- ][, .(train_ids, test_ids)]`
	`135`	`+ ][, list(train_ids, test_ids)]`
`136`	`136`	`train_ids = ids$train_ids`
`137`	`137`	`test_ids = ids$test_ids`
`138`	`138`	`}`
Original file line number	Diff line number	Diff line change
`@@ -100,7 +100,7 @@ as_task_fcst.data.frame = function(`
`100`	`100`
`101`	`101`	`has_dups = NULL`
`102`	`102`	`dup = if (has_key) {`
`103`		`- x[, .(has_dups = anyDuplicated(get(order)) > 0L), by = key][, any(has_dups)]`
	`103`	`+ x[, list(has_dups = anyDuplicated(get(order)) > 0L), by = key][, any(has_dups)]`
`104`	`104`	`} else {`
`105`	`105`	`anyDuplicated(x[[order]]) > 0L`
`106`	`106`	`}`
Original file line number	Diff line number	Diff line change
`@@ -82,7 +82,7 @@ read_tsf = function(file) {`
`82`	`82`	`}`
`83`	`83`	`}`
`84`	`84`
`85`		`- dt_long = dt[, .(value = strsplit1(value, ",")), by = col_names]`
	`85`	`+ dt_long = dt[, list(value = strsplit1(value, ",")), by = col_names]`
`86`	`86`	`dt_long["?", value := NA_character_, on = "value"]`
`87`	`87`	`dt_long[, value := as.numeric(value)]`
`88`	`88`	`dt[, value := NULL]`