Reduce allocations in ParseSize and PrettySize utility methods (#1404)

0xfeeddeadbeef · badrishc · web-flow · commit 6696b979af61 · 2025-10-09T11:16:00.000-07:00
Co-authored-by: Badrish Chandramouli &lt;badrishc@microsoft.com&gt;
diff --git a/libs/client/Utility.cs b/libs/client/Utility.cs
@@ -22,7 +22,7 @@ public static class Utility
         /// <returns>The number</returns>
         public static long ParseSize(string value)
         {
-            char[] suffix = ['k', 'm', 'g', 't', 'p'];
+            ReadOnlySpan<char> suffix = ['k', 'm', 'g', 't', 'p'];
             long result = 0;
             foreach (char c in value)
             {
@@ -83,7 +83,7 @@ public static long PreviousPowerOf2(long v)
         /// <returns></returns>
         internal static string PrettySize(long value)
         {
-            char[] suffix = ['K', 'M', 'G', 'T', 'P'];
+            ReadOnlySpan<char> suffix = ['K', 'M', 'G', 'T', 'P'];
             double v = value;
             int exp = 0;
             while (v - Math.Floor(v) > 0)
diff --git a/libs/server/Servers/ServerOptions.cs b/libs/server/Servers/ServerOptions.cs
@@ -239,7 +239,7 @@ public void GetSettings<TKey, TValue>()
         /// <returns></returns>
         public static long ParseSize(string value, out int bytesRead)
         {
-            char[] suffix = ['k', 'm', 'g', 't', 'p'];
+            ReadOnlySpan<char> suffix = ['k', 'm', 'g', 't', 'p'];
             long result = 0;
             bytesRead = 0;
             for (var i = 0; i < value.Length; i++)
@@ -289,7 +289,7 @@ public static bool TryParseSize(string value, out long size)
         /// <returns></returns>
         internal static string PrettySize(long value)
         {
-            char[] suffix = ['k', 'm', 'g', 't', 'p'];
+            ReadOnlySpan<char> suffix = ['k', 'm', 'g', 't', 'p'];
             double v = value;
             int exp = 0;
             while (v - Math.Floor(v) > 0)
diff --git a/libs/storage/Tsavorite/cs/src/core/Utilities/Utility.cs b/libs/storage/Tsavorite/cs/src/core/Utilities/Utility.cs
@@ -37,7 +37,7 @@ public static class Utility
         /// <returns>The number</returns>
         public static long ParseSize(string value)
         {
-            char[] suffix = ['k', 'm', 'g', 't', 'p'];
+            ReadOnlySpan<char> suffix = ['k', 'm', 'g', 't', 'p'];
             long result = 0;
             foreach (char c in value)
             {
@@ -97,7 +97,7 @@ internal static long PreviousPowerOf2(long v)
         /// <returns></returns>
         internal static string PrettySize(long value)
         {
-            char[] suffix = ['K', 'M', 'G', 'T', 'P'];
+            ReadOnlySpan<char> suffix = ['K', 'M', 'G', 'T', 'P'];
             double v = value;
             int exp = 0;
             while (v - Math.Floor(v) > 0)
@@ -345,7 +345,7 @@ private static async Task<T> SlowWithCancellationAsync<T>(Task<T> task, Cancella
         }
 
         /// <summary>
-        /// 
+        ///
         /// </summary>
         /// <returns></returns>
         public static ulong GetCurrentMilliseconds()

Original file line number	Diff line number	Diff line change
`@@ -22,7 +22,7 @@ public static class Utility`
`22`	`22`	`/// <returns>The number</returns>`
`23`	`23`	`public static long ParseSize(string value)`
`24`	`24`	`{`
`25`		`- char[] suffix = ['k', 'm', 'g', 't', 'p'];`
	`25`	`+ ReadOnlySpan<char> suffix = ['k', 'm', 'g', 't', 'p'];`
`26`	`26`	`long result = 0;`
`27`	`27`	`foreach (char c in value)`
`28`	`28`	`{`
`@@ -83,7 +83,7 @@ public static long PreviousPowerOf2(long v)`
`83`	`83`	`/// <returns></returns>`
`84`	`84`	`internal static string PrettySize(long value)`
`85`	`85`	`{`
`86`		`- char[] suffix = ['K', 'M', 'G', 'T', 'P'];`
	`86`	`+ ReadOnlySpan<char> suffix = ['K', 'M', 'G', 'T', 'P'];`
`87`	`87`	`double v = value;`
`88`	`88`	`int exp = 0;`
`89`	`89`	`while (v - Math.Floor(v) > 0)`
Original file line number	Diff line number	Diff line change
`@@ -37,7 +37,7 @@ public static class Utility`
`37`	`37`	`/// <returns>The number</returns>`
`38`	`38`	`public static long ParseSize(string value)`
`39`	`39`	`{`
`40`		`- char[] suffix = ['k', 'm', 'g', 't', 'p'];`
	`40`	`+ ReadOnlySpan<char> suffix = ['k', 'm', 'g', 't', 'p'];`
`41`	`41`	`long result = 0;`
`42`	`42`	`foreach (char c in value)`
`43`	`43`	`{`
`@@ -97,7 +97,7 @@ internal static long PreviousPowerOf2(long v)`
`97`	`97`	`/// <returns></returns>`
`98`	`98`	`internal static string PrettySize(long value)`
`99`	`99`	`{`
`100`		`- char[] suffix = ['K', 'M', 'G', 'T', 'P'];`
	`100`	`+ ReadOnlySpan<char> suffix = ['K', 'M', 'G', 'T', 'P'];`
`101`	`101`	`double v = value;`
`102`	`102`	`int exp = 0;`
`103`	`103`	`while (v - Math.Floor(v) > 0)`
`@@ -345,7 +345,7 @@ private static async Task<T> SlowWithCancellationAsync<T>(Task<T> task, Cancella`
`345`	`345`	`}`
`346`	`346`
`347`	`347`	`/// <summary>`
`348`		`- ///`
	`348`	`+ ///`
`349`	`349`	`/// </summary>`
`350`	`350`	`/// <returns></returns>`
`351`	`351`	`public static ulong GetCurrentMilliseconds()`