-
Notifications
You must be signed in to change notification settings - Fork 265
Closed
Labels
bugSomething isn't workingSomething isn't workingcode-analysisBugs that are reported by code analysis tools, but not the compilerBugs that are reported by code analysis tools, but not the compiler
Description
tests/RegistryTests.cpp has multiple instances of
REQUIRE_FAILED(false);
The REQUIRE_FAILED
macro checks an HRSESULT
, and false
will cast into an integer with a value of 0, which indicates success.
To fix, these should be explicit fails. Seeing as how catch2 is used, perhaps FAIL(<optional msg>);
is wanted instead. https://github.com/catchorg/Catch2/blob/devel/docs/skipping-passing-failing.md#top
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't workingcode-analysisBugs that are reported by code analysis tools, but not the compilerBugs that are reported by code analysis tools, but not the compiler