Skip to content

Commit 1338fd1

Browse files
authored
Update explanation md to clarify observer time as user time
1 parent 1109ee5 commit 1338fd1

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

plugins/CurrentWebsiteTimeZone/jp-guiang-explanation.md

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
1-
# Issue 1: Create a widget showing observer time and website time
1+
# Issue 1: Create a widget showing user local time and website time
22

3-
This is my first attempt at creating a widget that would show the observer local time and the website local time, if there were in different locations.
3+
This is my first attempt at creating a widget that would show the user's local time and the website's local time, if they were in different locations.
44

5-
I was only able to create a report widget that would show the local time of the website, and the other time is in UTC.
5+
I did not get to complete this task and was only able to create a report widget that would show the local time of the website. The other time that is shown is the current time in the UTC timezone.
66

77
I tried to create a test for this feature, but I was already reaching the end of the time I allocated myself for this task. If this were a typical work setting, I think I would have asked for help before writing any code, so I can learn the best practices of Matomo, and how another developer would have implemented this solution, as the code base is very new to me.
88

@@ -28,10 +28,10 @@ In hindsight I feel like I didn't needed to create a report for this feature. I
2828

2929
Since I also made most of the functionality in the API file, I couldn't figure out how to create tests for it within the time I allocated myself. If the functionality was in the `'GetLocalandWebsiteTime`' class, I may have had some extra time to create a test. But again, I'm not too sure that foregoing making it a report is the best solution for this feature as well.
3030

31-
## Proposed Solutions for getting observer timezone
31+
## Proposed Solutions for getting user's timezone
3232

3333
- Using session information like `'$_Session[user_timezone]'`
3434
- Using Carbon package
35-
-- I think this one is a bit too much just to get the observer timezone though
35+
-- I think this one is a bit too much just to get the user's timezone though
3636
- Using a Javascript Package like Day.js or Moment.js
37-
-- Moment.js will no longer a supported package though
37+
-- Moment.js will no longer a supported package though

0 commit comments

Comments
 (0)