Permalink
Checking mergeability…
Don’t worry, you can still create the pull request.
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
...
- 13 commits
- 9 files changed
- 2 contributors
Commits on Nov 21, 2023
-
changed false positive for namespace indentation error
changed return in IsBlockInNameSpace function
-
remove comments in CheckForNamespaceIndentation
erase other print statements for testing except original code.
Commits on Mar 31, 2024
Commits on Apr 23, 2024
-
Fix nearly all tests for namespace indentation
The only test that fails is for when the entire namespace, including the declaration, is indented. I'm not sure if we should support that usecase, but the error would also seem misleading.
-
Remove testWhitespaceBeforeNamespace
I don't think we should be supporting this case. Saying "don't indent namespaces" is also not very misleading.
-
-
-
Loading
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff develop...develop