feat: Add nft devnet, and hooks v2 testnet wallet inferencing #455
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvadari
reviewed
Oct 17, 2022
mvadari
reviewed
Oct 17, 2022
Co-authored-by: Mayukha Vadari <[email protected]>
mvadari
reviewed
Oct 24, 2022
mvadari
reviewed
Oct 24, 2022
Co-authored-by: Mayukha Vadari <[email protected]>
JST5000
reviewed
Oct 24, 2022
JST5000
reviewed
Oct 24, 2022
JST5000
reviewed
Oct 24, 2022
Collaborator
Author
|
Must implement hooks v2 fund given wallet still - working with Wietse on changing faucet to match other faucets |
…l-py into wallet-inference
Collaborator
Author
|
Separate hooks test into 2 to prevent need for 10 second timer |
JST5000
reviewed
Oct 26, 2022
mvadari
reviewed
Nov 2, 2022
mvadari
approved these changes
Nov 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
Allows inferencing for nft devnet, amm devnet, and hooks v2 testnet.
Context of Change
Seems like a nice quality of life upgrade for folks building with Hooks V2 testnet (https://hooks-testnet-v2.xrpl-labs.com/), which is a test network which is planned to be long-standing, and involves a feature we’d like more folks to play around with.. (It’s hard to find the URL for the hooks v2 testnet faucet, and generating new test accounts is a nice feature for test code)
Type of Change
Test Plan
Added unit and integration tests
Future Tasks
Should custom faucet paths be implemented like in XRPLF/xrpl.js#2083?