Skip to content

README の修正等 #105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 23, 2022
Merged

README の修正等 #105

merged 4 commits into from
Mar 23, 2022

Conversation

@PickledChair
Copy link
Member

@PickledChair PickledChair commented Mar 23, 2022 •
edited
Loading

内容

#99 のマージに際してやり残した修正です。

  • example/python/run.py の --root_path_dir 引数がなくなったので、それを README に反映
  • main ブランチとのコンフリクト解消時に core/CMakeLists.txt 内のインデントを適当にしてしまった部分の修正

y-chan
y-chan approved these changes Mar 23, 2022
View reviewed changes
Copy link
Member

@y-chan y-chan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMです！

Oyaki122
Oyaki122 approved these changes Mar 23, 2022
View reviewed changes
Copy link
Member

@Oyaki122 Oyaki122 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Oyaki122 Oyaki122 merged commit 43707a5 into VOICEVOX:main Mar 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@y-chan y-chan y-chan approved these changes

+1 more reviewer

@Oyaki122 Oyaki122 Oyaki122 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@PickledChair @y-chan @Oyaki122