scrape: use goquery.NewDocumentFromReader

willnorris · willnorris · commit 0fad29b18537 · 2019-10-16T08:24:00.000-07:00
goquery.NewDocumentFromResponse is deprecated
diff --git a/scrape/scrape.go b/scrape/scrape.go
@@ -105,7 +105,8 @@ func (c *Client) get(urlStr string, a ...interface{}) (*goquery.Document, error)
 		return nil, fmt.Errorf("received %v response fetching URL %q", resp.StatusCode, u)
 	}
 
-	doc, err := goquery.NewDocumentFromResponse(resp)
+	defer resp.Body.Close()
+	doc, err := goquery.NewDocumentFromReader(resp.Body)
 	if err != nil {
 		return nil, fmt.Errorf("error parsing response: %v", err)
 	}

Original file line number	Diff line number	Diff line change
`@@ -105,7 +105,8 @@ func (c Client) get(urlStr string, a ...interface{}) (goquery.Document, error)`
`105`	`105`	`return nil, fmt.Errorf("received %v response fetching URL %q", resp.StatusCode, u)`
`106`	`106`	`}`
`107`	`107`
`108`		`- doc, err := goquery.NewDocumentFromResponse(resp)`
	`108`	`+ defer resp.Body.Close()`
	`109`	`+ doc, err := goquery.NewDocumentFromReader(resp.Body)`
`109`	`110`	`if err != nil {`
`110`	`111`	`return nil, fmt.Errorf("error parsing response: %v", err)`
`111`	`112`	`}`