Skip to content

Conversation

@mtygesen
Copy link
Contributor

  • Added search bar to search for places and transitions in a net

@mtygesen mtygesen marked this pull request as ready for review April 3, 2025 15:22
@srba srba self-requested a review April 3, 2025 15:31
Copy link
Member

@srba srba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works very well. It is nice that for places it prints (Shared) after the shared places, please, do the same also for shared transitions.

@srba srba self-requested a review April 4, 2025 19:10
Copy link
Member

@srba srba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR is broken. Open e.g. the EKR net and search for RP place. It shows is as a shared place (but it is not a shared place). When you click it, it gives:

Exception in thread "AWT-EventQueue-0" java.lang.IllegalStateException: Selected object is null
at pipe.gui.GuiFrame.lambda$buildToolbar$4(GuiFrame.java:997)
at pipe.gui.petrinet.SearchBar.lambda$showResults$0(SearchBar.java:149)
at java.desktop/javax.swing.AbstractButton.fireActionPerformed(AbstractButton.java:1972)
at java.desktop/javax.swing.AbstractButton$Handler.actionPerformed(AbstractButton.java:2314)
at java.desktop/javax.swing.DefaultButtonModel.fireActionPerformed(DefaultButtonModel.java:407)
at java.desktop/javax.swing.DefaultButtonModel.setPressed(DefaultButtonModel.java:262)
...

@srba srba self-requested a review April 7, 2025 18:35
Copy link
Member

@srba srba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and works very well.

@srba srba merged commit 33f5702 into TAPAAL:main Apr 7, 2025
1 check passed
@mtygesen mtygesen deleted the search-components branch April 10, 2025 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants