-
Notifications
You must be signed in to change notification settings - Fork 10
Closed
Closed
Copy link
Labels
devRequires technical expertiseRequires technical expertise
Description
Why?
As a user, I expect the default column types to have correct sorting behaviour.
Currently sorting is always done alpha-numerically, if not explicitly overriden.
Acceptance criteria
- all
DefaultSupportedTypesare sorted as expected, e.g.numberis sorted numerically, so100>9dateis numerically by its timestamp, sonew Date("2020-02-01")>new Date("2020-01-01")
- like in the renderer.ts it is required through typing, that every possible
DefaultSupportedTypeshas a defined sorting - the sortFunction to use is determined by the following priority list, the first defined one is used:
sortFuncdefined via columnConfigsortFuncdefined via custom type[Renderer]Sortings (see nice-to-have)sortFuncdefined from the default types, if matching- fallback sort function
nice-to-have
-
theuseSortingsSortOptionsis extended to allow the users to define sorting based on aTypeRenderertype
Implementation details
- The default sortings should located in the
OnyxDataGrid/features/sortingdirectory/files. - the generic TTypeRenderer type is passed through to the
Definition of Done
-
Should be covered by tests:
- functional tests (Playwright or unit test)
- visual tests (Playwright screenshots)
-
Make sure, that
- follow-up tickets were created if necessary
- updated version + documentation is deployed
- Storybook can show the feature
- Storybook code snippet of new/changed examples are checked that they are generated correctly
- Namings are aligned with Figma
Approval
- Checked and approved by
Metadata
Metadata
Assignees
Labels
devRequires technical expertiseRequires technical expertise
Type
Projects
Status
Done