Describe the Bug
New Campaign Properties dialog #5657 due in 1.19 closes and loses any changes if there are sight/light/aura syntax errors and the user presses OK.
Previous behavior (i.e. in 18.5) is to stay open and allow the user to correct the syntax errors, or to click Cancel.
To Reproduce
Run Develop or a current nightly build
Open Campaign Properties
Add an incorrect sight, light, or aura definition (e.g. error: blah)
Click OK
Observe Feedback dialog, press OK
Observe Error dialog, press OK
Campaign Properties dialog closes and any changes are lost
Expected Behaviour
New Campaign Properties dialog to stay open after syntax errors detected to give the user the opportunity to fix the syntax errors, or to click Cancel.
Screenshots
Then Campaign Dialog closes.
MapTool Info
Develop, current nightly builds
Desktop
No response
Additional Context
Found when developing new custom halos #5824, as this was also affected by the CD dialog closing when syntax errors were detected.