Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: ProtonMail/go-crypto
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v1.1.5
Choose a base ref
...
head repository: ProtonMail/go-crypto
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v1.1.6
Choose a head ref
  • 16 commits
  • 12 files changed
  • 6 contributors

Commits on Feb 3, 2025

  1. fix(packet): PublicKey.KeyIdString must return a valid key id

    PublicKey.KeyIdString previously did not compute the key ID correctly for v5 and v6 keys.
    This commit fixes the issue by directly using the stored key ID from the struct.
    lubux committed Feb 3, 2025
    Configuration menu
    Copy the full SHA
    f621215 View commit details
    Browse the repository at this point in the history

Commits on Feb 12, 2025

  1. Merge pull request #269 from ProtonMail/fix/v6-key-id-pub

    Fix: PublicKey.KeyIdString must return a valid key id
    
    PublicKey.KeyIdString() previously did not compute the key ID correctly for v5 and v6 keys.
    This PR fixes the issue by directly using the stored key ID from the struct.
    lubux authored Feb 12, 2025
    Configuration menu
    Copy the full SHA
    30af2e4 View commit details
    Browse the repository at this point in the history

Commits on Feb 20, 2025

  1. Switch to advanced CodeQL configuration

    In order to enable CodeQL scanning on PRs from forks.
    twiss authored Feb 20, 2025
    Configuration menu
    Copy the full SHA
    397d579 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #274 from ProtonMail/advanced-codeql-config

    Switch to advanced CodeQL configuration
    twiss authored Feb 20, 2025
    Configuration menu
    Copy the full SHA
    ef10ec5 View commit details
    Browse the repository at this point in the history
  3. Allows Key Flags override, fixes #205

    Added InsecureAllowAllKeyFlagsWhenMissing to packet.Config.
    Allows usage of keys without key flags.
    davrux authored and twiss committed Feb 20, 2025
    Configuration menu
    Copy the full SHA
    68c5c41 View commit details
    Browse the repository at this point in the history
  4. Merge pull request #272 from davrux/main

    Allows Key Flags override, fixes #205
    twiss authored Feb 20, 2025
    Configuration menu
    Copy the full SHA
    cfbd6f6 View commit details
    Browse the repository at this point in the history

Commits on Feb 21, 2025

  1. Only check that message signatures are newer than the key

    Don't check that binding signatures are newer than the primary key
    that created them, as some old keys generated by previous versions
    of OpenPGP.js fail this check.
    twiss committed Feb 21, 2025
    Configuration menu
    Copy the full SHA
    8e272e7 View commit details
    Browse the repository at this point in the history

Commits on Feb 24, 2025

  1. Merge pull request #275 from ProtonMail/only-check-msg-sig-newer-than…

    …-key
    
    Only check that message signatures are newer than the key
    lubux authored Feb 24, 2025
    Configuration menu
    Copy the full SHA
    2732e09 View commit details
    Browse the repository at this point in the history

Commits on Feb 27, 2025

  1. Configuration menu
    Copy the full SHA
    2b2dbe9 View commit details
    Browse the repository at this point in the history
  2. Only check that message signatures are newer than the key

    Don't check that binding signatures are newer than the primary key
    that created them, as some old keys generated by previous versions
    of OpenPGP.js fail this check.
    twiss authored and lubux committed Feb 27, 2025
    Configuration menu
    Copy the full SHA
    89b0776 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    b105e24 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    44ef98c View commit details
    Browse the repository at this point in the history
  5. Make Issuer Key ID signature subpacket non-critical

    RPM <=4.16 does not support it.
    caarlos0 authored and twiss committed Feb 27, 2025
    Configuration menu
    Copy the full SHA
    756ebbd View commit details
    Browse the repository at this point in the history
  6. Merge pull request #266 from caarlos0/issuer-key-id

    Make Issuer Key ID signature subpacket non-critical
    twiss authored Feb 27, 2025
    Configuration menu
    Copy the full SHA
    d47bb38 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    4bf9d90 View commit details
    Browse the repository at this point in the history
  8. Merge pull request #271 from ProtonMail/feat/improve-errors-key-selec…

    …tion
    
    v2 API: Improve error messages for encryption key selection
    
    This PR enhances error messages by providing detailed explanations 
    when key selection for encryption fails in the v2 API.
    lubux authored Feb 27, 2025
    Configuration menu
    Copy the full SHA
    e52eada View commit details
    Browse the repository at this point in the history
Loading