Fix issue with URL params not updating when un-maximizing a module.

iftenney · LIT team · commit 406fbc7690ee · 2024-02-15T19:08:18.000-08:00
Previously, this did not clear the expanded_module= bit, so sharing a link or
refreshing the page would cause the module to maximize again.

PiperOrigin-RevId: 607529159
diff --git a/lit_nlp/client/core/widget_group.ts b/lit_nlp/client/core/widget_group.ts
@@ -99,8 +99,7 @@ export class WidgetGroup extends ReactiveElement {
 
     // Maximization.
     const onMaxClick = () => {
-      this.maximized = !this.maximized;
-      this.setMaximized(this.maximized);
+      this.setMaximized(!this.maximized);
       this.setMinimized(false);
     };
 
@@ -114,7 +113,7 @@ export class WidgetGroup extends ReactiveElement {
     const onTitleClick = () => {
       if (this.minimized) {
         this.setMinimized(false);
-        this.maximized = false;
+        this.setMaximized(false);
       }
     };
 
@@ -220,7 +219,8 @@ export class WidgetGroup extends ReactiveElement {
     // For clicks on the maximized-module darkened background, undo the
     // module maximization.
     const onBackgroundClick = () => {
-      this.maximized = false;
+      this.setMaximized(false);
+      this.setMinimized(false);
     };
     // A listener to stop clicks on a maximized module from causing the
     // background click listener from firing.
