-
Notifications
You must be signed in to change notification settings - Fork 463
Comparing changes
Open a pull request
base repository: KhronosGroup/MoltenVK
base: v1.4.1
head repository: KhronosGroup/MoltenVK
compare: main
- 8 commits
- 16 files changed
- 2 contributors
Commits on Nov 26, 2025
-
Fix buffer and heap out-of-sync in initExternalMemory()
If a buffer is created before a heap in MVKDeviceMemory, the buffer would be used in some places (for example `MVKDeviceMemory::map` and the heap would be used in other places (for example `MVKBuffer::getMTLBuffer()`). This leads to inconsistent memory mappings. Specifically, there are two cases when this happens: 1. When `vkAllocateMemory` is called with an imported buffer. 2. When `vkAllocateMemory` expects `HANDLE_TYPE_MTLBUFFER` to be exported. In either case, `ensureMTLBuffer()` gets called before `ensureMTLHeap()` which sets `_mtlBuffer` to a buffer not allocated from the placement heap. This change fixes this by making sure that if a placement heap is needed, we will always create it prior to allocating the buffer. In cases where the heap is not used at all (imported buffer), we will return error if the user tries to specify a `HANDLE_TYPE_MTLHEAP` for export.
Configuration menu - View commit details
-
Copy full SHA for 8961682 - Browse repository at this point
Copy the full SHA 8961682View commit details
Commits on Dec 1, 2025
-
Fix incorrect varable usage in
MVKImagePlane::getMTLTexture()`_mtlTexture` can still be nil at this point which means that we may have a memoryless texture attempt to get added to the residency set.
Configuration menu - View commit details
-
Copy full SHA for d748ad7 - Browse repository at this point
Copy the full SHA d748ad7View commit details -
Introduce KHR_external_semaphore_fd only for FD==-1
There is a special use case for when importing/exporting a semaphore of handle type `VK_EXTERNAL_SEMAPHORE_HANDLE_TYPE_SYNC_FD_BIT` and FD == -1. According to the Vulkan specs, calling `vkImportSemaphoreFdKHR` has the effect of signaling the binary semaphore and calling `vkGetSemaphoreFdKHR` has the effect of waiting on the binary semaphore. Outside of KHR_external_semaphore_fd extension, there is no other way to achieve this behaviour. For example, `vkWaitSemaphores` does not operate on a binary semaphore and there is no other defined way for a CPU to send a signal operation. In theory, we can use EXT_metal_objects and export the VkSemaphore to a `MTLSharedEvent` but we do not have access to the `MVKSemaphoreMTLEvent` in order to determine the `_mtlEventValue` (last encoded wait value). This functionality is required to implement Venus on macOS which uses these functions to synchronize the guest semaphore state to the host.
Configuration menu - View commit details
-
Copy full SHA for 2f1358e - Browse repository at this point
Copy the full SHA 2f1358eView commit details
Commits on Dec 12, 2025
-
Merge pull request #2669 from osy/submit/fix-getmtltexture
Fix incorrect variable usage in `MVKImagePlane::getMTLTexture()`
Configuration menu - View commit details
-
Copy full SHA for 4055c60 - Browse repository at this point
Copy the full SHA 4055c60View commit details -
Merge pull request #2670 from osy/submit/semaphore-fd
Introduce KHR_external_semaphore_fd only for FD==-1
Configuration menu - View commit details
-
Copy full SHA for 2c3f25d - Browse repository at this point
Copy the full SHA 2c3f25dView commit details -
Merge pull request #2667 from osy/main
Fix buffer and heap out-of-sync in initExternalMemory()
Configuration menu - View commit details
-
Copy full SHA for d6d49e0 - Browse repository at this point
Copy the full SHA d6d49e0View commit details
Commits on Dec 13, 2025
-
- Update to latest SPIRV-Cross. - Add top CMake file to Xcode projects to support editing versions in future. - Update documentation.
Configuration menu - View commit details
-
Copy full SHA for 9b11b2a - Browse repository at this point
Copy the full SHA 9b11b2aView commit details -
Merge pull request #2673 from billhollings/update-version
Update version to 1.4.2.
Configuration menu - View commit details
-
Copy full SHA for bf60f60 - Browse repository at this point
Copy the full SHA bf60f60View commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff v1.4.1...main