Skip to content

Conversation

@Madeorsk
Copy link
Collaborator

#2990

Following up our discussions, transform the third resource detail in a resource subtitle.

@Madeorsk Madeorsk added the 👷‍♂️ Work In Progress PR en cours de développement label Oct 24, 2025
@Madeorsk Madeorsk changed the title Search fields layout Search fields layout with subtitle Oct 24, 2025
@Madeorsk Madeorsk force-pushed the search-fields-layout branch from 1ceca6a to 77a45a6 Compare October 24, 2025 14:32
@Madeorsk Madeorsk requested a review from ThieryMichel October 24, 2025 15:37
@Madeorsk Madeorsk added 👷‍♂️ Ready For Review PR en attente de relecture et de validation and removed 👷‍♂️ Work In Progress PR en cours de développement labels Oct 24, 2025
cy.contains('Save', { timeout: 500 }).click({
force: true,
});
cy.wait(3000);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you need to add a wait here ?
Is it possible to detect a progressbar / notification instead?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you need to add a wait here ?

We need to wait for the save request to be fully done before reloading the page, otherwise the enrichment isn't saved yet when the page reload. I don't know why we didn't get it before.
Maybe I could track the notification or wait for the save button to be enabled again (it gets disabled when saving).

Copy link
Collaborator Author

@Madeorsk Madeorsk Oct 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't find a way to get it to work every time when I use the save button state... I don't really understand what's happening here, but with this small wait, the test always pass, and without it, it fails randomly.

@Madeorsk Madeorsk force-pushed the search-fields-layout branch from f367039 to d8d5721 Compare October 27, 2025 14:01
@Madeorsk Madeorsk requested a review from ThieryMichel October 27, 2025 14:03
@ThieryMichel ThieryMichel merged commit a3a0977 into v16 Oct 27, 2025
10 checks passed
@ThieryMichel ThieryMichel deleted the search-fields-layout branch October 27, 2025 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

👷‍♂️ Ready For Review PR en attente de relecture et de validation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants