Skip to content

Conversation

tmatsuo
Copy link
Contributor

@tmatsuo tmatsuo commented Mar 26, 2015

No description provided.

@tmatsuo
Copy link
Contributor Author

tmatsuo commented Mar 26, 2015

@lesv Can you take a look?

@tmatsuo
Copy link
Contributor Author

tmatsuo commented Mar 26, 2015

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perhaps two counters.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, done

@lesv
Copy link
Contributor

lesv commented Mar 27, 2015

All else looks good.

@tmatsuo
Copy link
Contributor Author

tmatsuo commented Mar 27, 2015

PTAL

lesv added a commit that referenced this pull request Mar 27, 2015
Extracted code snippets from the unittest docs and added travis config.
@lesv lesv merged commit 463ded2 into GoogleCloudPlatform:master Mar 27, 2015
tswast added a commit that referenced this pull request Mar 17, 2016
kurtisvg added a commit that referenced this pull request Oct 11, 2018
Shabirmean pushed a commit that referenced this pull request Nov 9, 2022
* Add code snippets for Service Directory.

Initially reviewed in pull request: github.com//pull/2538

These are expected to be added to go on our docs site page: cloud.google.com/service-directory/docs/configuring-service-directory

* inline some stuff in EndpointsCreate snippet.

* chore: update libraries-bom to 4.4.0 (#26)

This PR was generated using Autosynth. 🌈

Synth log will be available here:
https://source.cloud.google.com/results/invocations/46cdbcfa-1e99-4e4f-be05-90f447630a24/targets

* chore(deps): update dependency com.google.cloud.samples:shared-configuration to v1.0.15 (#29)

This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [com.google.cloud.samples:shared-configuration](https://togithub.com/GoogleCloudPlatform/java-repo-tools) | patch | `1.0.14` -> `1.0.15` |

---

### Release Notes

<details>
<summary>GoogleCloudPlatform/java-repo-tools</summary>

### [`v1.0.15`](https://togithub.com/GoogleCloudPlatform/java-repo-tools/releases/v1.0.15)

[Compare Source](https://togithub.com/GoogleCloudPlatform/java-repo-tools/compare/v1.0.14...v1.0.15)

-   Move some stuff around (in prep for a change to release process) pom.xml's
-   Add an exclude filter for SpotBugs. (disable the Java 11 surprise)
-   Don't fail on SpotBugs issues for now
-   add PMD reporting
-   Don't fail on PMD issues for now.

</details>

---

### Renovate configuration

:date: **Schedule**: At any time (no schedule defined).

:vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

:recycle: **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

:no_bell: **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#googleapis/java-servicedirectory).

* deps: update dependency org.threeten:threetenbp to v1.4.3 (#14)

This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [org.threeten:threetenbp](https://www.threeten.org/threetenbp) ([source](