Skip to content

Change 'BatchSettings.max_bytes' default. #5899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 7, 2018
Merged

Change 'BatchSettings.max_bytes' default. #5899

merged 1 commit into from
Sep 7, 2018

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Sep 7, 2018

It is documented as '10MB', but enforced as 10000000 bytes.

Closes #5898.

@tseaver
Change 'BatchSettings.max_bytes' default.
a0de2d8 
It is documented as '10MB', but enforced as 10000000 bytes.

Closes #5898.
@tseaver tseaver added the api: pubsub Issues related to the Pub/Sub API. label Sep 7, 2018
@tseaver tseaver requested a review from theacodes September 7, 2018 14:33
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 7, 2018
@tseaver tseaver merged commit cbf90ec into googleapis:master Sep 7, 2018
@tseaver tseaver deleted the 5898-pubsub-fix-batch_settings-max_bytes branch September 7, 2018 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@theacodes theacodes theacodes approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
api: pubsub Issues related to the Pub/Sub API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tseaver @theacodes @googlebot