fix(Singleton): remove potential issue on windows

BotellaA · web-flow · commit 3aa225b3f42e · 2019-10-07T10:51:00.000+02:00
diff --git a/.github/workflows/CI.yml b/.github/workflows/CI.yml
@@ -0,0 +1,46 @@
+name: CI
+
+on: 
+  push:
+  pull_request:
+
+jobs:
+  format:
+    runs-on: ubuntu-18.04
+    
+    steps:
+      - uses: actions/checkout@v1
+      - uses: Geode-solutions/actions/clang-format@master
+        env:
+          GITHUB_TOKEN: ${{ secrets.TOKEN }}
+      
+  build:
+    runs-on: ${{ matrix.os }}
+    needs: format
+
+    strategy:
+      matrix:
+        node-version: [10.x, 12.x]
+        os: [ubuntu-18.04, windows-2016, macOS-10.14]
+
+    steps:
+    - uses: actions/checkout@v1
+    - name: Use Node.js ${{ matrix.node-version }}
+      uses: actions/setup-node@v1
+      with:
+        node-version: ${{ matrix.node-version }}
+    - name: npm install and build
+      run: |
+        npm install
+        npm run examples
+        
+  semantic-release:
+    runs-on: ubuntu-18.04
+    needs: build
+    steps:
+    - uses: actions/checkout@v1
+    - run: npx semantic-release
+      env:
+        GITHUB_TOKEN: ${{ secrets.TOKEN }}
+        NPM_TOKEN: ${{ secrets.NPM_TOKEN }}
+    
diff --git a/.releaserc b/.releaserc
@@ -3,7 +3,6 @@
     '@semantic-release/commit-analyzer', 
     '@semantic-release/release-notes-generator', 
     '@semantic-release/github',
-    '@semantic-release/npm',
-    'semantic-release-ado'
+    '@semantic-release/npm'
   ]
 }
diff --git a/README.md b/README.md
@@ -2,14 +2,14 @@
 <h3 align="center">Automatic generation of N-API wrapper from a C++ library</h3>
 
 <p align="center">
-  <img src="https://dev.azure.com/GeodeSolutions/Geode/_apis/build/status/Geode-solutions.genepi?branchName=master" alt="Build Status">
+  <img src="https://github.com/Geode-solutions/genepi/workflows/CI/badge.svg" alt="Build Status">
   <img src="https://img.shields.io/github/release/Geode-solutions/genepi.svg" alt="Version">
 </p>
 
 <p align="center">
-  <img src="https://dev.azure.com/GeodeSolutions/Geode/_apis/build/status/Geode-solutions.genepi?branchName=master&jobName=Test&configuration=Test%20Windows&label=Windows" alt="Windows Build Status">
-  <img src="https://dev.azure.com/GeodeSolutions/Geode/_apis/build/status/Geode-solutions.genepi?branchName=master&jobName=Test&configuration=Test%20Ubuntu&label=Linux" alt="Linux Build Status">
-  <img src="https://dev.azure.com/GeodeSolutions/Geode/_apis/build/status/Geode-solutions.genepi?branchName=master&jobName=Test&configuration=Test%20Mac&label=macOS" alt="Apple Build Status">
+  <img src="https://img.shields.io/static/v1?label=Windows&logo=windows&logoColor=white&message=support&color=success" alt="Windows support">
+  <img src="https://img.shields.io/static/v1?label=Linux&logo=linux&logoColor=white&message=support&color=success" alt="Linux support">
+  <img src="https://img.shields.io/static/v1?label=macOS&logo=apple&logoColor=white&message=support&color=success" alt="macOS support">
 </p>
 
 <p align="center">
diff --git a/azure-pipelines.yml b/azure-pipelines.yml
diff --git a/examples/functions/functions.cpp b/examples/functions/functions.cpp
@@ -40,15 +40,15 @@ namespace foo
     {
         std::cout << "Hello, " << name << std::endl;
     }
-}
+} // namespace foo
 
 #include <genepi/genepi.h>
 
 namespace
 {
     GENEPI_FUNCTION( sayHello );
     NAMED_GENEPI_FUNCTION( sayBye, sayGoodbye );
-}
+} // namespace
 
 namespace foo
 {
diff --git a/examples/overloaded-functions/overloaded-functions.cpp b/examples/overloaded-functions/overloaded-functions.cpp
@@ -46,6 +46,6 @@ namespace
     GENEPI_MULTIFUNCTION( test, void, test_string, const std::string& );
     GENEPI_MULTIFUNCTION( test, void, test_int, int );
     GENEPI_MULTIFUNCTION( test, void, test_int2, int, int );
-}
+} // namespace
 
 GENEPI_MODULE( overloaded_functions );
diff --git a/include/genepi/type_list.h b/include/genepi/type_list.h
@@ -76,7 +76,8 @@ namespace genepi
     };
 
     template < template < typename... > class Output,
-        template < size_t, typename > class Mapper,
+        template < size_t, typename >
+        class Mapper,
         typename... Args >
     struct MapWithIndex
     {
diff --git a/src/genepi/singleton.cpp b/src/genepi/singleton.cpp
@@ -24,6 +24,7 @@
 #include <genepi/singleton.h>
 
 #include <map>
+#include <string>
 
 namespace genepi
 {
@@ -46,7 +47,7 @@ namespace genepi
         }
 
     private:
-        std::map< const char *, std::unique_ptr< Singleton > > singletons_;
+        std::map< std::string, std::unique_ptr< Singleton > > singletons_;
     };
 
     Singleton::Singleton() : impl_( new Impl ) {}
diff --git a/test/test.cpp b/test/test.cpp
diff --git a/test/test.js b/test/test.js

Original file line number	Diff line number	Diff line change
`@@ -3,7 +3,6 @@`
`3`	`3`	`'@semantic-release/commit-analyzer',`
`4`	`4`	`'@semantic-release/release-notes-generator',`
`5`	`5`	`'@semantic-release/github',`
`6`		`- '@semantic-release/npm',`
`7`		`- 'semantic-release-ado'`
	`6`	`+ '@semantic-release/npm'`
`8`	`7`	`]`
`9`	`8`	`}`
Original file line number	Diff line number	Diff line change
`@@ -40,15 +40,15 @@ namespace foo`
`40`	`40`	`{`
`41`	`41`	`std::cout << "Hello, " << name << std::endl;`
`42`	`42`	`}`
`43`		`-}`
	`43`	`+} // namespace foo`
`44`	`44`
`45`	`45`	`#include <genepi/genepi.h>`
`46`	`46`
`47`	`47`	`namespace`
`48`	`48`	`{`
`49`	`49`	`GENEPI_FUNCTION( sayHello );`
`50`	`50`	`NAMED_GENEPI_FUNCTION( sayBye, sayGoodbye );`
`51`		`-}`
	`51`	`+} // namespace`
`52`	`52`
`53`	`53`	`namespace foo`
`54`	`54`	`{`
Original file line number	Diff line number	Diff line change
`@@ -76,7 +76,8 @@ namespace genepi`
`76`	`76`	`};`
`77`	`77`
`78`	`78`	`template < template < typename... > class Output,`
`79`		`- template < size_t, typename > class Mapper,`
	`79`	`+ template < size_t, typename >`
	`80`	`+ class Mapper,`
`80`	`81`	`typename... Args >`
`81`	`82`	`struct MapWithIndex`
`82`	`83`	`{`
Original file line number	Diff line number	Diff line change
`@@ -24,6 +24,7 @@`
`24`	`24`	`#include <genepi/singleton.h>`
`25`	`25`
`26`	`26`	`#include <map>`
	`27`	`+#include <string>`
`27`	`28`
`28`	`29`	`namespace genepi`
`29`	`30`	`{`
`@@ -46,7 +47,7 @@ namespace genepi`
`46`	`47`	`}`
`47`	`48`
`48`	`49`	`private:`
`49`		`- std::map< const char *, std::unique_ptr< Singleton > > singletons_;`
	`50`	`+ std::map< std::string, std::unique_ptr< Singleton > > singletons_;`
`50`	`51`	`};`
`51`	`52`
`52`	`53`	`Singleton::Singleton() : impl_( new Impl ) {}`