feat: determine domains from ParticleCollection #45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This does not affect the ranges of the QN domains!
Codecov Report
@@ Coverage Diff @@
## main #45 +/- ##
==========================================
+ Coverage 94.19% 94.23% +0.04%
==========================================
Files 15 15
Lines 2825 2846 +21
==========================================
+ Hits 2661 2682 +21
Misses 164 164
Flags with carried forward coverage won't be shown. Click here to find out more.
|
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From ComPWA/expertsystem#486, but adapted so that ranges are generated: if there is some
Particlein the insertedParticleCollectionwith spin-1.5, the range will be[0, 0.5, 1, 1.5](not just[1.5]). Also allows setting the maximum spin in LS-couplings.This will facilitate #40