Skip to content

Conversation

@redeboer
Copy link
Member

No description provided.

@redeboer redeboer added the 📝 Docs Improvements or additions to documentation label Apr 15, 2021
@redeboer redeboer added this to the 0.8.0 milestone Apr 15, 2021
@redeboer redeboer self-assigned this Apr 15, 2021
@codecov
Copy link

codecov bot commented Apr 15, 2021

Codecov Report

Merging #44 (9a35396) into main (687e5e2) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #44   +/-   ##
=======================================
  Coverage   94.19%   94.19%           
=======================================
  Files          15       15           
  Lines        2825     2825           
=======================================
  Hits         2661     2661           
  Misses        164      164           
Flag Coverage Δ
unittests 94.19% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@redeboer redeboer merged commit 1b08c48 into main Apr 15, 2021
@redeboer redeboer deleted the improve-docs branch April 15, 2021 18:58
redeboer pushed a commit to redeboer/ComPWA-qrules that referenced this pull request Apr 30, 2022
Intensity and Amplitude design rework and log likelihood estimator
tests:
- Huge rework for Intensity and Amplitude related classes (Closes ComPWA#130)
  The instrinsic normalization feature was removed, as well as the
  PartialAmplitude and Resonance class. Different Amplitude classes
  follow the decorator pattern and can be combined! Because the
  normalization feature was removed also the MinLogLH class was
  reworked completely.
- The classes Intensity, Amplitude, Kinematics are now pure interface
  classes.
- Introduced a bunch of builder functions in the IntensityBuilderXML
  namespace which are now responsible for creating the intensities,
  amplitudes, and kinematics objects from xml files. This removes the
  interdependencies of concrete instances of these object. Also the new
  builder functions can now more easily create arbitrarily complicated
  intensities from the xml file (Closes ComPWA#141).
- The Estimator interface was improved.
- FunctionTree feature for Estimators was decoupled to improve
  modularity. Now there exists a FunctionTreeEstimator wrapper class.
- Improved the Event and DataPoint data structures. They are now simple
  data structures, which are stored in std::vector containers.
- Started to remove unneccesary shared_ptr usage, which can lead to bad
  code design.
- General code improvements, for code that was related to the rework
  above.
- Introduced a test cases using the log likelihood estimator
  (MinLogLH). One test performs verification of error estimations also
  on events with weights (Closes ComPWA#44).
- Changed the hierarchy of the logging levels to TRACE, DEBUG, INFO,
  WARNING, ERROR, FATAL (default: INFO)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

📝 Docs Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants