-
Notifications
You must be signed in to change notification settings - Fork 131
Open
Description
There are three issues in the end city generation:
- Bridges are added to
baseinstead offloor
Infinders.c->genTower():Piece *bridge = addEndCityPiece(env, base, brot, binfo[i][1], binfo[i][2], binfo[i][3], BRIDGE_END);
This incorrectly attaches bridges to base. They should be attached to floor.
- End ship assigned to
baseincorrectly
Infinders.c->genBridge():base = addEndCityPiece(env, base, rot, x, y, z, END_SHIP);
This modifies base. The final BRIDGE_END in genBridge should attach to the last BRIDGE_PIECE or stair, not the ship.
- Depth type is too small
Infinders.h->STRUCT(Piece):int8_t depth;
In end city generation, depth is set usingint gendepth = next(env->rng, 32);ingenPiecesRecusively(). Using int32_t prevents overflow.
Example: Seed 155040604429240, Chunk (122, 80) generates an end city where these issues are observed.
Metadata
Metadata
Assignees
Labels
No labels