PersistenceExceptionConverter NPE

rhollencamp · web-flow · commit eb990bcf2308 · 2025-03-27T09:01:35.000Z
make sure SQLException#getSQLState is not null before attempting to call methods on it. I have observed exceptions during AWS MySQL RDS failovers where sql state is null, causing this method to throw an NPE exception rather than the expected ModelException closes keycloak#38467 Signed-off-by: Robert Hollencamp <rhollencamp@cargurus.com>
diff --git a/model/jpa/src/main/java/org/keycloak/connections/jpa/PersistenceExceptionConverter.java b/model/jpa/src/main/java/org/keycloak/connections/jpa/PersistenceExceptionConverter.java
@@ -91,10 +91,7 @@ public static ModelException convert(Throwable t) {
         Predicate<Throwable> throwModelDuplicateEx = throwable ->
                 throwable instanceof EntityExistsException
                 || throwable instanceof ConstraintViolationException
-                // SQL state class 23 captures errors like 23505 = UNIQUE VIOLATION et al.
-                // This captures, for example, a BatchUpdateException which is not mapped to the other exception types
-                // https://en.wikipedia.org/wiki/SQLSTATE
-                || (throwable instanceof SQLException bue && bue.getSQLState().startsWith("23"))
+                || isSqlStateClass23(throwable)
                 || throwable instanceof SQLIntegrityConstraintViolationException;
 
         throwModelDuplicateEx = throwModelDuplicateEx.or(checkDuplicationMessage);
@@ -110,4 +107,15 @@ public static ModelException convert(Throwable t) {
         }
     }
 
+    /**
+     * SQL state class 23 captures errors like 23505 = UNIQUE VIOLATION et al.
+     * This captures, for example, a BatchUpdateException which is not mapped to the other exception types
+     * https://en.wikipedia.org/wiki/SQLSTATE
+     */
+    private static boolean isSqlStateClass23(Throwable t) {
+        return t instanceof SQLException bue
+            && bue.getSQLState() != null
+            && bue.getSQLState().startsWith("23");
+    }
+
 }
