Skip to content

Conversation

@akoumpa
Copy link
Collaborator

@akoumpa akoumpa commented Mar 31, 2025

Important

The Update branch button must only be pressed in very rare occassions.
An outdated branch is never blocking the merge of a PR.
Please reach out to the automation team before pressing that button.

What does this PR do ?

Adding the __init__.py otherwise the "automodel" directory is not being included, as Python isn't seeing it as a package.

Collection: [Note which collection this PR will affect]

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

Signed-off-by: Alexandros Koumparoulis <[email protected]>
@akoumpa akoumpa marked this pull request as ready for review March 31, 2025 16:16
@akoumpa akoumpa requested a review from chtruong814 March 31, 2025 16:16
@akoumpa
Copy link
Collaborator Author

akoumpa commented Mar 31, 2025

If all looks ok, please force-merge to reduce CI workload, since it's only adding a __init__.py file. Thanks.

@chtruong814 chtruong814 merged commit d5cc22e into main Mar 31, 2025
33 checks passed
@chtruong814 chtruong814 deleted the akoumparouli/fix_automodel_dir branch March 31, 2025 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants