feat: Added client memory stats + cleaned up diagnostics prefabs (refreshed) #337
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BrandonChanSkybox
approved these changes
Dec 4, 2025
Contributor
BrandonChanSkybox
left a comment
There was a problem hiding this comment.
LGTM as far as I can understand
frgarc
approved these changes
Dec 4, 2025
| return ( | ||
| <div> | ||
| <h2>{title}</h2> | ||
| <div style={{ flexDirection: 'row', display: 'flex', width: '100%' }}> |
There was a problem hiding this comment.
It would be cleaner to have all the styles into CSS files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a refresh of the original PR for this work #316 by @JakeShirley
Minecraftpe change to support the client memory stats is in PR.
Reviewing
Only the last two commits are new - some typo fixes + adding a tab for global dynamic properties which was implemented after the original PR.
Testing
Verified that all diagnostic tabs are still working. In particular client memory and dynamic properties: