feat: Add ability to see global dynamic property values in the Debugger Window #324
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SBLMikeDemone
approved these changes
Sep 11, 2025
Contributor
SBLMikeDemone
left a comment
There was a problem hiding this comment.
Nice, thanks for iterating with me!
chmeyer-ms
reviewed
Sep 11, 2025
chmeyer-ms
reviewed
Sep 11, 2025
chmeyer-ms
reviewed
Sep 11, 2025
chmeyer-ms
reviewed
Sep 11, 2025
chmeyer-ms
approved these changes
Sep 12, 2025
SBLMikeDemone
requested changes
Sep 17, 2025
Contributor
SBLMikeDemone
left a comment
There was a problem hiding this comment.
I think the react caching will rebuild every tick unnecessarily
webview-ui/src/diagnostics_panel/controls/MinecraftDynamicPropertiesTable.tsx
Show resolved
Hide resolved
SBLMikeDemone
approved these changes
Sep 17, 2025
Contributor
SBLMikeDemone
left a comment
There was a problem hiding this comment.
Looks good! I'd recommend doing a stress test where you have 100s of dynamic properties that are all updating and adding and removing at different intervals and make sure this still works well
webview-ui/src/diagnostics_panel/controls/MinecraftDynamicPropertiesTable.tsx
Show resolved
Hide resolved
SBLMikeDemone
approved these changes
Sep 19, 2025
d2bc512 to
46c564a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sends Global Dynamic Property Values to the Debugger
Allows users to see all Global Dynamic Properties listed in a grid.
The Grid shows names in one column, and the values of the dynamic properties in the other