This repository was archived by the owner on Sep 8, 2024. It is now read-only.
Fix reference leak when using bus.remove_all_listeners #2375
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This cleans up the extra skills references making the ref count trigger correctly.
The threaded event emitter did not remove the wrapper mapping when remove_all_events were called causing trailing references to objects.
Ensure that the event scheduler shutdown removes the all references in the ThreadedEventEmitter.
chrisveilleux
approved these changes
Nov 7, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The remove_all_listeners did not remove the appropriate wrapper mapping leaving trailing references to skills if a scheduled repeating event was used.
This also removes a couple of circular references (doing no real harm) to get the ref-count debug code to report correctly.
How to test
See the new test case.
Contributor license agreement signed?
CLA [ Yes ]