This repository was archived by the owner on Sep 8, 2024. It is now read-only.
Fallback to Mimic if launch of TTS fails #2374
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Logs the exception and fallsback to Mimic as TTS backend if there is an issue with the selected TTS backend or if the choice is invalid.
31b199f to
c832852
Compare
chrisveilleux
approved these changes
Oct 29, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Logs the exception and fallsback to Mimic as TTS backend if there is an
issue with the selected TTS backend or if the choice is invalid. Resolves #1518.
How to test
Make sure audio service starts as expected. Trigger an exception in the
__init__()or validator of a TTS and verify that it falls back to mimic and logs the issue.Contributor license agreement signed?
CLA [ Yes ]