This repository was archived by the owner on Sep 8, 2024. It is now read-only.
Add missing __delitem__ method #2354
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The delitem method is apparently used, for example by the alarm skill
e9423e6 to
24d6cf9
Compare
davidwagnerkc
approved these changes
Oct 7, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
__delitem__method is apparently used, for example by the alarm skill. This will allow the alarm to actually be stopped.How to test
Set an alarm and view the CLI, repeatedly screaming stop at the device should stop the deluge of errors and allow interactions again. The mute of output during listening will probably make the alarm be inaudible still...
Contributor license agreement signed?
CLA [ Yes ]