Thanks, looks like a very useful tool. We have an optional pre-commit hook which is based on pycodestyle should this also be upgraded to use flake8 or should the pycodestyle module be kept side by side of flake8?

I usually run Python Software Foundation’s black in my precommit which effectively makes pycodestyle unnecessary.

Flake8 is a superset of pyflakes + pycodestyle + McCabe complexity analysis + it adds its own issue codes. Running flake8 unrestricted will execute all of the pycodestyle tests and will add many others besides. Here we have focused flake8 on a handful of errors codes that effect runtime safety or correctness.

Hello, @cclauss, thank you for helping with the Mycroft project! We welcome everyone
into the community and greatly appreciate your help as we work to build an AI
for Everyone.

To protect yourself, the project, and users of Mycroft technologies we require
a Contributor Licensing Agreement (CLA) before accepting any code
contribution. This agreement makes it crystal clear that along with your
code you are offering a license to use it within the confines of this project.
You retain ownership of the code, this is just a license.

Please visit https://mycroft.ai/cla to initiate this one-time signing. Thank
you!

WTF w the CLA checker?

It's job was blocked and just ran now. You've not been added to the CLA list, I've sent an email to @krisgesling since he manually flipped you to "CLA: Yes" to check the status and why you weren't added.

Bump on this one...

Thanks, can you look at the python 3.8 failure as well? (or maybe split that out into a separate PR if it's tricky)

We need to either restore pycodestyle to the test-requirements.txt or remove/update the precommit-hook util that's using it.

flake8 is a superset of pycodestyle so installing flake8 will also install pycodestyle.

Ok NOW I get it, sorry for being dense. This looks very nice. Merging

Thanks for this.