This repository was archived by the owner on Sep 8, 2024. It is now read-only.
Prevent unneeded mimic compilation in dev_setup.sh #957
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code that detected existing mimic installs and asked for confirmation before rebuilding had a few holes: * A source install of mimic under the mycroft-core tree was missed * Hitting "enter" or "spacebar" would be interpreted as "yes, rebuild", which didn't match the prompt.
Contributor
Author
|
Ping |
aatchison
approved these changes
Aug 12, 2017
Contributor
aatchison
left a comment
There was a problem hiding this comment.
This looks good, and functions. Thanks!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code that detected existing mimic installs and asked for
confirmation before rebuilding had a few holes:
which didn't match the prompt.