NTLM: disable if DES support missing from OpenSSL or mbedTLS #19206
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make autotools and cmake detect DES support in OpenSSL and mbedTLS.
Forward feature macros to C and omit NTLM from the feature preview list.
Use the feature macros in source. This ensure that
-Voutput matchesthe preview.
OpenSSL doesn't support DES when built with
no-desorno-deprecated.mbedTLS 4.x no longer supports it, and it's possible to disable it in
<4 with
scripts/config.py unset MBEDTLS_DES_C.Before this patch this worked for
mbedTLS 4 only, and with a regression for pending PR #16973.
Also:
drop NTLM feature check from
curl_setup.hin favour of autotools/cmake feature macros. This makes
curl_setup.hno longer needto include an mbedTLS header, which in turn makes tests/server build
without depending on mbedTLS.
Fixing, in cmake: define dependencies as
IMPORTEDinterface targets #16973:Ref: https://github.com/curl/curl/actions/runs/18689537893/job/53291322012?pr=16973
Ref: build: move NTLM guard definitions to
curl_ntlm_core.h#19181 (initial fix idea)Follow-up to 3a30583 mbedtls: add support for 4.0.0 #19077
move back mbedTLS header include and version check from
curl_setup.hto each source which consumes mbedTLS.GHA/http3-linux: drop workaround that disabled NTLM for
no-deprecatedOpenSSL builds.Follow-up to 0069778 openssl: fix building with v3
no-deprecated+ add CI test #12384curl_ntlm_core: drop pointless macro
CURL_NTLM_NOT_SUPPORTED.Follow-up to 0069778 openssl: fix building with v3
no-deprecated+ add CI test #12384