schannel: handle Curl_conn_cf_send() errors better #19265
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Analysis of PR #19265 at 5fc3b1e2: Test ../../tests/http/test_17_ssl_use.py::TestSSLUse::test_17_20_correct_pin[h3] failed, which has NOT been flaky recently, so there could be a real issue in this PR. Note that this test has failed in 2 different CI jobs (the link just goes to one of them). Generated by Testclutch |
Avoid a resource leak in the error path. Reported-by: Joshua Rogers Closes #19265
5fc3b1e to
293ca6c
Compare
Member
Author
|
This change is larger than necessary, but I do want to also take the opportunity to slowly improve the function to increase readability and become less "entangled". |
Member
|
IMO it isn't easier to read and #19244 was better. However it is not incorrect. |
jay
approved these changes
Oct 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid a resource leak in the error path.
Reported-by: Joshua Rogers