Skip to content

schannel: Do not leak memory on failed setting algorithm cipher list #19118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
MegaManSec wants to merge 3 commits into from
Closed

schannel: Do not leak memory on failed setting algorithm cipher list #19118

MegaManSec wants to merge 3 commits into from

Conversation

@MegaManSec
Copy link
Contributor

@MegaManSec MegaManSec commented Oct 18, 2025

Discovered by ZeroPath.

@github-actions github-actions bot added TLS Windows Windows-specific labels Oct 18, 2025
@MegaManSec
Copy link
Contributor Author

MegaManSec commented Oct 18, 2025

P.S: It's not clear whether backend->cred->cred_handle needs to be freed in case of if(sspi_status != SEC_E_OK). If it does, probably the latest Curl_safefree(backend->cred); should be replaced with schannel_session_free().

@bagder
Copy link
Member

bagder commented Oct 18, 2025

@jay what do you say?

@bagder bagder requested a review from jay October 18, 2025 21:23
jay
jay requested changes Oct 18, 2025
View reviewed changes
@jay jay closed this in 66e3ff5 Oct 19, 2025
@jay
Copy link
Member

jay commented Oct 19, 2025

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jay jay jay requested changes

Assignees

No one assigned

Labels

TLS Windows Windows-specific

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MegaManSec @bagder @jay