Skip to content

version: add GSS backend name and version #19073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
vszakats wants to merge 10 commits into from
Closed

version: add GSS backend name and version #19073

vszakats wants to merge 10 commits into from

Conversation

@vszakats
Copy link
Member

@vszakats vszakats commented Oct 15, 2025 •
edited
Loading

MIT Kerberos version detection is implemented for autotools and cmake.

Examples:

curl 8.17.0-DEV (x86_64-pc-linux-gnu) ... mbedTLS/3.6.4 libidn2/2.3.7 nghttp2/1.59.0 libgss/1.0.4 OpenLDAP/2.6.7
curl 8.17.0-DEV (x86_64-pc-linux-gnu) ... LibreSSL/4.1.1 libidn2/2.3.7 nghttp2/1.59.0 mit-krb5/1.20.1 OpenLDAP/2.6.7
curl 8.17.0-DEV (x86_64-pc-linux-gnu) ... LibreSSL/4.1.1 libidn2/2.3.7 nghttp2/1.59.0 mit-krb5 OpenLDAP/2.6.7
curl 8.17.0-DEV (x86_64-pc-linux-gnu) ... LibreSSL/4.1.1 nghttp2/1.59.0 mit-krb5/1.20.1 OpenLDAP/2.6.7
curl 8.17.0-DEV (aarch64e-apple-darwin24.6.0) ... GnuTLS/3.8.10 libidn2/2.3.8 libssh2/1.11.1 nghttp2/1.67.1 mit-krb5/1.22.1

Also:

  • cmake/FindGSS: strip project name ("Kerberos 5 release") from
    the version string when detected via krb5-config.
  • fix for Found GSS: MIT (found version "Kerberos 5 release 1.22.1")
  • "MIT-Kerberos" → "mit-krb5"
  • detect MIT Kerberos with autotools? (Not feeling the vibe for that) [DONE]

@vszakats vszakats marked this pull request as draft October 15, 2025 13:39
@vszakats vszakats marked this pull request as ready for review October 15, 2025 14:38
@vszakats
autotools: add MIT Kerberos version detection
adcfc5d
@vszakats
version.c bump buffer to fit an odd full version number
33d0d69 
In case the stripping logic isn't successful.

"1234567890123456789012345678901234567890"
"Kerberos 5 release 1.23.45-prerelease"
@vszakats
formatting
c36c371
@vszakats
fixup comments
c5ef016
@vszakats
cleanup
eaf6643
@vszakats
autotools log cleanup
930c738
bagder
bagder approved these changes Oct 16, 2025
View reviewed changes
Copy link
Member

@bagder bagder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@vszakats vszakats closed this in 1a81a8e Oct 16, 2025
@vszakats vszakats deleted the gssver branch October 16, 2025 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bagder bagder bagder approved these changes

Assignees

No one assigned

Labels

authentication

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vszakats @bagder