thread: errno on thread creation #18998
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When thread creation fails, the code uses `errno` to remember the cause. But pthread_create() never sets errno and gives the error as return value. Fix that by setting the return value into errno on failure. Windows: I think the ifdef was the wrong way around. Also set a generic Windows Error code on CE systems. reported-by: Joshua Rogers
bagder
approved these changes
Oct 10, 2025
vszakats
added a commit
to vszakats/curl
that referenced
this pull request
Oct 10, 2025
Both WinCE and Windows use CreateThread() now, so the use of `GetLastError()` works for both. Follow-up to 03448f4 curl#18998 Follow-up to 1c49f2f curl#18451 Follow-up to af02162 curl#1589
Member
|
Nice catch, yes. In #19015 I went along to delete the fallback branch. It became unnecessary |
vszakats
added a commit
to vszakats/curl
that referenced
this pull request
Oct 10, 2025
Both WinCE and Windows use `CreateThread()` now, so the use of `GetLastError()` works for both. Follow-up to 03448f4 curl#18998 Follow-up to 1c49f2f curl#18451 Follow-up to af02162 curl#1589 Closes curl#19015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When thread creation fails, the code uses
errnoto remember the cause. But pthread_create() never sets errno and gives the error as return value. Fix that by setting the return value into errno on failure.Windows: I think the ifdef was the wrong way around. Also set a generic Windows Error code on CE systems.
reported-by: Joshua Rogers