kerberos: bump minimum to 1.3 (2003-07-08), drop legacy logic #18992
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Drop logic detecting this header, and drop alternate logic including a bare "gssapi.h". Bare `gssapi.h` is Heimdal-specific. MIT Kerberos added support for it for Heimdal compatibility on 2006-11-09, redirecting to `gssapi/gssapi.h`. MIT Kerberos supported the latter header in the 1990s already. Ref: 40e1a01 (2008-03-06) Ref: krb5/krb5@d119352 (2006-11-09)
Added in 2010 to support "ancient distros such as RHEL-3". Where `gssapi/gssapi_krb5.h` did not include `gssapi/gssapi.h`. Probably not an issue with supported distros. MIT Kerberos did the same since commit: krb5/krb5@d9e959e (2003-03-06) Released in 1.3. Heimdal included the main header from its initial commit in: heimdal/heimdal@bef2219 (2006-10-08) Reverting cca192e (2010-04-16)
From 1.2.4 (2002-02-28)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous minimum was: 1.2.4 (2002-02-28)
assume
gssapi/gssapi.hheader for MIT Kerberos.Drop logic detecting this header, and drop alternate logic including
a bare "gssapi.h". Bare
gssapi.his Heimdal-specific. MIT Kerberosadded support for it for Heimdal compatibility on 2006-11-09,
redirecting to
gssapi/gssapi.h. MIT Kerberos supported the latterheader in the 1990s already.
Ref: 40e1a01 (2008-03-06)
Ref: krb5/krb5@d119352 (2006-11-09)
configure.ac: stop using
HAVE_GSSAPI_GSSAPI_H.Added in 2010 to support "ancient distros such as RHEL-3" where
gssapi/gssapi_krb5.hdid not includegssapi/gssapi.h.MIT Kerberos includes it since commit:
krb5/krb5@d9e959e (2003-03-06)
Released in 1.3 (2003-07-08).
Bump minimum required version to avoid this issue.
Reverts cca192e (2010-04-16)
Ref: https://web.mit.edu/kerberos/dist/historic.html
Ref: https://sources.debian.org/src/krb5/
gssapi/gssapi_generic.h#18990CMake/FindGSS.cmake.