Skip to content

Conversation

@icing
Copy link
Contributor

@icing icing commented Oct 2, 2025

No description provided.

}
}
else if(data)
else
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it worth adding as an assert in the beginning of the function?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe then the analyzers freak out again.

@vszakats
Copy link
Member

vszakats commented Oct 2, 2025

@testclutch
Copy link

Analysis of PR #18804 at d3246073:

Test ../../tests/http/test_16_info.py::TestInfo::test_16_01_info_download[h3] failed, which has NOT been flaky recently, so there could be a real issue in this PR. Note that this test has failed in 2 different CI jobs (the link just goes to one of them).

Generated by Testclutch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

4 participants