Skip to content

Conversation

@vszakats
Copy link
Member

@vszakats vszakats commented Oct 6, 2025

  • fix CURLcode vs. LDAP result code confusion.
    Return LDAP_NO_MEMORY when Curl_create_sspi_identity() fails,
    since it can only return CURLE_OUT_OF_MEMORY as error.
  • use ULONG for result code on Windows. Drop casts.
  • use portable curl_ldap_num_t. Drop casts.
  • replace magic number 0 with LDAP_SUCCESS.
  • compare with LDAP_SUCCESS instead of assuming non-zero.
    (where necessary.)
  • add/fix #endif comments.
  • fix indentation.

w/o sp https://github.com/curl/curl/pull/18888/files?w=1

@vszakats vszakats added the LDAP label Oct 6, 2025
@vszakats vszakats changed the title ldap: tidy-up types ldap: tidy-up types, fix error code confusion Oct 6, 2025
@vszakats vszakats closed this in ef1794e Oct 6, 2025
@vszakats vszakats deleted the wldaperr branch October 6, 2025 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

1 participant