ldap: tidy-up types, fix error code confusion #18888
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CURLcodevs. LDAP result code confusion.Return
LDAP_NO_MEMORYwhenCurl_create_sspi_identity()fails,since it can only return
CURLE_OUT_OF_MEMORYas error.ULONGfor result code on Windows. Drop casts.curl_ldap_num_t. Drop casts.LDAP_SUCCESS.LDAP_SUCCESSinstead of assuming non-zero.(where necessary.)
#endifcomments.w/o sp https://github.com/curl/curl/pull/18888/files?w=1