Skip to content

cf-socket: check params and remove accept procondition #18882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
icing wants to merge 1 commit into from
Closed

cf-socket: check params and remove accept procondition #18882

icing wants to merge 1 commit into from
+15 −13

Conversation

@icing
Copy link
Contributor

@icing icing commented Oct 6, 2025 •
edited
Loading

  • creating a socket filter with NULL addrinfo fails with CURLE_BAD_FUNCTION_ARGUMENT
  • remove getsockname use before accept call, serves no purpose and did not lead to proper error before

reported-by: Joshua Rogers

@icing
cf-socket: check params and remove accept procondition
fa98d91 
- creating a socket filter with NULL addrinfo fails with
  CURLE_BAD_FUNCTION_ARGUMENT
- remove getsockname use before accept call, serves no purpose
  and did not lead to proper error before
@icing icing requested a review from bagder October 6, 2025 12:25
@bagder bagder closed this in 2f3cf17 Oct 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bagder bagder bagder approved these changes

Assignees

No one assigned

Labels

connecting & proxies

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@icing @bagder