libssh2: error check and null-terminate in ssh_state_sftp_readdir_link() #18598
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reported-by: Joshua Rogers
Member
|
|
bagder
approved these changes
Sep 18, 2025
Member
Author
Yes, that's where I patched, or wasn't I? Unless I missing something the null-termination seems to be fixed since libssh2 A negative check looks necessary though to avoid continuing with an uninitialized |
libssh2_sftp_symlink_ex()ssh_state_sftp_readdir_link()
ssh_state_sftp_readdir_link()
vszakats
added a commit
to vszakats/curl
that referenced
this pull request
Sep 18, 2025
One of these was added in the initial SFTP commit in 2006: a634f64 At that time this was a reasonable concern because libssh2 started null-terminating this string just one year prior: libssh2/libssh2@efc3841 This fix was released in libssh2 v0.13. curl requires libssh v1.2.8, making this workaround no longer necessary. Follow-up to 9f18cb6 curl#18598
vszakats
added a commit
that referenced
this pull request
Sep 19, 2025
The null-termination was first added in the initial SFTP commit in 2006: a634f64 At that time this was a reasonable concern because libssh2 started null-terminating this string just one year prior, in 2005: libssh2/libssh2@efc3841 This fix was released in libssh2 v0.13 (2006-03-02). curl requires libssh2 v1.2.8, making this workaround no longer necessary. Follow-up to 9f18cb6 #18598 Closes #18606
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
null-terminate the result to match the other getter
libssh2_sftp_symlink_ex()call.check negative result and bail out early.
Reported-by: Joshua Rogers