Skip to content

Conversation

@vszakats
Copy link
Member

@vszakats vszakats commented Sep 14, 2025

CI.md slipped into the 8.15.0, 8.16.0 tarballs by accident.
Remove it again and update the checker exception.

Follow-up to fa3f889 #17463

@vszakats vszakats added tests tidy-up dist CI Continuous Integration labels Sep 14, 2025
@vszakats vszakats changed the title docs: drop CI.md from tarball dist: drop CI.md from tarball Sep 14, 2025
@bagder
Copy link
Member

bagder commented Sep 15, 2025

The way this is worded right now, it sounds like we remove a file from the tarball. In reality it just removes a path from a list that identifies a non-existing file since it was moved from there previously.

@vszakats vszakats changed the title dist: drop CI.md from tarball dist: do not distributed CI.md Sep 15, 2025
@vszakats vszakats changed the title dist: do not distributed CI.md dist: do not distribute CI.md Sep 15, 2025
@vszakats
Copy link
Member Author

vszakats commented Sep 15, 2025

This patch also removes CI.md from the tarball. CI.md wasn't part of it before
8.15.0. I assume this was by intent, because no CI-related file is distributed. Then,
while moving test .md files to their new location, CI.md got into the tarball. My
understanding is that this may have been unintented. Is this incorrect? (The exception
list needs to be updated either way.)

(I adjusted the title and text to better tell this.)

@bagder
Copy link
Member

bagder commented Sep 15, 2025

Aha. Yeah, since nothing CI related is included anyway I figure maybe the docs doesn't belong there. I don't feel strongly either way.

@vszakats vszakats closed this in e09f45f Sep 15, 2025
@vszakats vszakats deleted the t-ci-dist branch September 15, 2025 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI Continuous Integration dist tests tidy-up

Development

Successfully merging this pull request may close these issues.

2 participants