Skip to content

Conversation

@icing
Copy link
Contributor

@icing icing commented Aug 26, 2025

Restructured the code in the following ways:

  • add terminal states SUCCESS and FAILED
  • split SOCK4 and SOCK5 states to be more clear
  • use bufq for send/recv of SOCK messages
  • reduce SOCKS4 states, more speaking names
  • for most states, move code into static function
  • reduce SOCKS5 states, more speaking names
  • add helpers for traversing to FAILED state
  • add helper to flush bufq
  • add hepler to read minimum amount into bufq

@github-actions github-actions bot added the tests label Aug 26, 2025
@icing icing added connecting & proxies WebSocket feature-window A merge of this requires an open feature window and removed WebSocket labels Aug 26, 2025
@icing icing marked this pull request as ready for review August 26, 2025 15:11
@icing icing requested a review from bagder August 26, 2025 15:11
Restructured the code in the following ways:

* add terminal states SUCCESS and FAILED
* split SOCK4 and SOCK5 states to be more clear
* use `bufq` for send/recv of SOCK messages
* reduce SOCKS4 states, more speaking names
* for most states, move code into static function
* reduce SOCKS5 states, more speaking names
* add helpers for traversing to FAILED state
* add helper to flush bufq
* add hepler to read minimum amount into bufq
@bagder bagder closed this in ccd2b03 Sep 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

connecting & proxies feature-window A merge of this requires an open feature window tests

Development

Successfully merging this pull request may close these issues.

2 participants