Skip to content

write-out: make %header{} able to output *all* occurances of a header #18491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
bagder wants to merge 3 commits into from
Closed

write-out: make %header{} able to output *all* occurances of a header #18491

bagder wants to merge 3 commits into from

Conversation

@bagder
Copy link
Member

@bagder bagder commented Sep 8, 2025

By appending :all:[separator] to the header name. The [separator] string is output between each header value if there are more than one to output.

Test 764 verifies

Idea-by: kapsiR on github
Ref: #18449

@bagder bagder added cmdline tool feature-window A merge of this requires an open feature window labels Sep 8, 2025
@github-actions github-actions bot added the tests label Sep 8, 2025
@kapsiR
Copy link

kapsiR commented Sep 8, 2025

Great! Thanks for the quick implementation!

I don't know the curl internals enough, the only thing I'd mention here is, if there is a possibility of a recursion, should there any handling for that? (or is this not possible due to the redirect implementation?)

@bagder
Copy link
Member Author

bagder commented Sep 8, 2025

I don't know the curl internals enough, the only thing I'd mention here is, if there is a possibility of a recursion, should there any handling for that? (or is this not possible due to the redirect implementation?)

That's not a risk here. There are several different ways those are prevented (before this code runs): there's a maximum redirections to follow value (--max-redirs, 50 by default) and there is a maximum number of headers curl will record before it returns error.

@bagder bagder marked this pull request as ready for review September 8, 2025 06:48
@testclutch

This comment was marked as outdated.

Sign in to view
@bagder bagder force-pushed the bagder/writeout-all-headers branch from f61a564 to dfcfad2 Compare September 8, 2025 14:33
bagder added a commit that referenced this pull request Sep 8, 2025
@bagder
write-out: make %header{} able to output *all* occurances of a header
15c2c93 
By appending `:all:[separator]` to the header name. The `[separator]` string
is output between each header value if there are more than one to output.

Test 764 and 765 verify

Idea-by: kapsiR on github
Ref: #18449
Closes #18491
@bagder bagder force-pushed the bagder/writeout-all-headers branch from dfcfad2 to 15c2c93 Compare September 8, 2025 21:27
@bagder
write-out: make %header{} able to output *all* occurances of a header
6abe788 
By appending `:all:[separator]` to the header name. The `[separator]` string
is output between each header value if there are more than one to output.

Test 764 and 765 verify

Idea-by: kapsiR on github
Ref: #18449
Closes #18491
@bagder
fixup language
eaae8bc
@bagder
fixup simplify condition
6f2b4a3
@bagder bagder force-pushed the bagder/writeout-all-headers branch from 15c2c93 to 6f2b4a3 Compare September 9, 2025 13:48
@bagder bagder closed this in 3dad0cf Sep 20, 2025
@bagder bagder deleted the bagder/writeout-all-headers branch September 20, 2025 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

cmdline tool feature-window A merge of this requires an open feature window tests

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bagder @kapsiR @testclutch