upgrade/multiplex handling #18227
Closed
upgrade/multiplex handling #18227
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bagder
reviewed
Aug 8, 2025
bagder
approved these changes
Aug 8, 2025
|
ping @bagder |
db4d4eb to
4ad9cb7
Compare
|
ping @icing |
Contributor
Author
|
Yeah, this one got lost a bit. But since we just did rc3, I think we hold it for after the release. |
Improvements around HTTP Upgrade: and multiplex hanndling: * add `Curl_conn_set_multiplex()` to set connection's multiplex bit and trigger "connchanged" events * call `Curl_conn_set_multiplex()` in filters' `CF_CTRL_CONN_INFO_UPDATE` implementation where other connection properties are updated. This prevents connection updates before the final filter chain is chosen. * rename enum `UPGR101_INIT` to `UPGR101_NONE` * rename connection bit `asks_multiplex` to `upgrade_in_progress` * trigger "connchanged" when `upgrade_in_progress` clears * rename `WebSockets` to `WebSocket` as it is the common term used in documentation
4ad9cb7 to
421dcaf
Compare
bagder
approved these changes
Sep 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improvements around HTTP Upgrade: and multiplex hanndling:
Curl_conn_set_multiplex()to set connection's multiplex bit and trigger "connchanged" eventsCurl_conn_set_multiplex()in filters'CF_CTRL_CONN_INFO_UPDATEimplementation where other connection properties are updated. This prevents connection updates before the final filter chain is chosen.UPGR101_INITtoUPGR101_NONEasks_multiplextoupgrade_in_progressupgrade_in_progressclearsWebSocketstoWebSocketas it is the common term used in documentation