Skip to content

Conversation

kamalaboulhosn
Copy link
Contributor

Use flow control as a means to limit the messages in the gRPC buffer, which can cause issue for ordered delivery.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 24, 2020
@codecov
Copy link

codecov bot commented Jun 24, 2020

Codecov Report

Merging #267 into master will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #267      +/-   ##
============================================
+ Coverage     79.17%   79.20%   +0.02%     
  Complexity      316      316              
============================================
  Files            21       21              
  Lines          2877     2880       +3     
  Branches        153      153              
============================================
+ Hits           2278     2281       +3     
  Misses          537      537              
  Partials         62       62              
Impacted Files Coverage Δ Complexity Δ
...in/java/com/google/cloud/pubsub/v1/Subscriber.java 80.00% <ø> (ø) 22.00 <0.00> (ø)
...cloud/pubsub/v1/StreamingSubscriberConnection.java 65.18% <100.00%> (+0.79%) 9.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 099eae5...c9c2028. Read the comment docs.

@kamalaboulhosn kamalaboulhosn merged commit 9c750c8 into googleapis:master Jun 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants